Re: [PATCH] pager: disable color when pager is "more"

From: Jeff King <peff@peff.net>
Date: Jul 18, 2016, 13:16 UTC
Message-ID: <20160718131653.GC19751@sigill.intra.peff.net>
In-Reply-To: <20160718091907.GA13588@starla>

On Mon, Jul 18, 2016 at 09:19:07AM +0000, Eric Wong wrote:

Show 17 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > On Sun, 17 Jul 2016, norm@dad.org wrote:
> > > 'git diff' outputs escape characters which clutter my terminal. Yes, I
> > > can sed them out, but then why are they there?
> > 
> > Those are most likely the ANSI sequences to add color. Can you call Git
> > with the --no-color option and see whether the escape characters go away?
> 
> Norm: do you have PAGER=more set by any chance?
> Perhaps changing it to "less" will allow you to preserve colors.
> 
> I saw a similar or identical problem during my vacation in
> FreeBSD-land.  Perhaps the out-of-the-box experience can be
> improved:
> 
> -----8<-----
> Subject: [PATCH] pager: disable color when pager is "more"

This is the tip of a smaller iceberg. See

  http://public-inbox.org/git/52D87A79.6060600%40rawbw.com/t/#u

for more discussion, and some patches that fix more cases (like "LESS" without "R", or "more" that _does_ understand "R"). I think it was discarded as being a little too intimate with the details of pagers, but it does suck that the out-of-the-box experience on FreeBSD is not good. Maybe we should revisit it.

-Peff