Re: [PATCH 1/2] commit: be more precise when searching for headers

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2017, 19:18 UTC
Message-ID: <xmqq8torxx15.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <23989e76-24ba-90a4-91a9-9f66bfccb7c9@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 9 quoted lines

> Search for a space character only within the current line in
> read_commit_extra_header_lines() instead of searching in the whole
> buffer (and possibly beyond, if it's not NUL-terminated) and then
> discarding any results after the end of the current line.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  commit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Makes sense.

Show 15 quoted lines

> diff --git a/commit.c b/commit.c
> index 2cf85158b4..173c6d3818 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -1354,8 +1354,8 @@ static struct commit_extra_header *read_commit_extra_header_lines(
>  		strbuf_reset(&buf);
>  		it = NULL;
>  
> -		eof = strchr(line, ' ');
> -		if (next <= eof)
> +		eof = memchr(line, ' ', next - line);
> +		if (!eof)
>  			eof = next;
>  
>  		if (standard_header_field(line, eof - line) ||