git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] commit: be more precise when searching for headers

From
Jeff King <peff@peff.net>
Date
Feb 25, 2017, 20:12 UTC
Message-ID
<20170225201238.wkujdwg4jyvovelm@sigill.intra.peff.net>
In-Reply-To
<23989e76-24ba-90a4-91a9-9f66bfccb7c9@web.de>
On Sat, Feb 25, 2017 at 08:21:52PM +0100, René Scharfe wrote:
Show 10 quoted lines
> Search for a space character only within the current line in
> read_commit_extra_header_lines() instead of searching in the whole
> buffer (and possibly beyond, if it's not NUL-terminated) and then
> discarding any results after the end of the current line.
> [...]
> -		eof = strchr(line, ' ');
> -		if (next <= eof)
> +		eof = memchr(line, ' ', next - line);
> +		if (!eof)
>  			eof = next;
Nice. More efficient, and I think the intent is more clear.
-Peff
Previous: René ScharfeNext: Junio C Hamano
Message 8 of 9 in “commit: be more precise when searching for headers”
  1. 1/2 commit: be more precise when searching for headersRené Scharfe, Feb 25, 2017
  2. 2/2 commit: don't check for space twice when looking for headerRené Scharfe, Feb 25, 2017
  3. Jeff KingFeb 25, 2017
  4. René ScharfeFeb 25, 2017
  5. Jeff KingFeb 25, 2017
  6. Jakub NarębskiFeb 27, 2017
  7. René ScharfeFeb 27, 2017
  8. Jeff KingFeb 25, 2017
  9. Junio C HamanoFeb 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.