Re: [PATCH 0/6] Create Git/Packet.pm

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 22, 2017, 02:04 UTC
Message-ID: <xmqq8tg4djkm.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171019123030.17338-1-chriscool@tuxfamily.org>

Christian Couder <christian.couder@gmail.com> writes:

> Goal
> ~~~~

Totally offtopic, but is it only me who finds these "section headers" in cover letters from some people irritating and/or jarring? It perhaps is because I view the cover letter more as a part of conversation, not a presentation. And when you walk up to somebody and start a conversation, you do not declare section headers ;-)

Saying "I want to be able to do these things in the future, and here is to prepare for that future" at the beginning nevertheless is a good thing. It gives us readers an overall vision we can agree to (or be against, or offer alternatives) and sets expectations on what the series would do and where it stops and leaves the remainder to follow-up work.

> Packet related functions in Perl can be useful to write new filters or
> to debug or test existing filters. So instead of having them in
> t0021/rot13-filter.pl, let's extract them into a new Git/Packet.pm
> module.

I left some comments on individual patches to point out places that may need improvements. I agree with the overall direction.

Thanks for starting this topic.