Re: [PATCH 4/6] t0021/rot13-filter: add packet_initialize()

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 27, 2017, 05:07 UTC
Message-ID: <CAP8UFD34O7RyXo0QErrQ0A-gbKRy8m6ChP_osQm-SdmD3qtx9g@mail.gmail.com>
In-Reply-To: <xmqqr2tpcn6g.fsf@gitster.mtv.corp.google.com>

On Fri, Oct 27, 2017 at 4:57 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> It is fine to leave the original code broken at this step while we
>> purely move the lines around, and hopefully this will be corrected
>> in a later step in the series (I am responding as I read on, so I do
>> not yet know at which patch that happens in this series).
>
> Actually, I think you'd probably be better off if you fixed these
> broken comparisions that does (@list1 eq @list2) very early in the
> series, perhaps as [PATCH 0.8/6].

Yeah, it's better to fix the comparisons first.

> I am sure Perl experts among us on the list can come up with a
> cleaner and better implementation of compare_lists sub I am adding
> here, but in the meantime, here is what I would start with if I were
> working on this topic.

Thanks for the patch, Christian.