Re: [PATCH 6/6] Add Git/Packet.pm from parts of t0021/rot13-filter.pl

From: Stefan Beller <sbeller@google.com>
Date: Oct 19, 2017, 22:06 UTC
Message-ID: <CAGZ79kYTLrLJ22cn+yYbV8sTK-NAaeF4EcnnBj29Tt5Q7URi1g@mail.gmail.com>
In-Reply-To: <20171019123030.17338-7-chriscool@tuxfamily.org>

On Thu, Oct 19, 2017 at 5:30 AM, Christian Couder <christian.couder@gmail.com> wrote:

Show 21 quoted lines

> And while at it let's simplify t0021/rot13-filter.pl by
> using Git/Packet.pm.
>
> This will make it possible to reuse packet related
> functions in other test scripts.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  perl/Git/Packet.pm      | 118 ++++++++++++++++++++++++++++++++++++++++++++++++
>  t/t0021/rot13-filter.pl |  94 ++------------------------------------
>  2 files changed, 121 insertions(+), 91 deletions(-)
>  create mode 100644 perl/Git/Packet.pm
>
> diff --git a/perl/Git/Packet.pm b/perl/Git/Packet.pm
> new file mode 100644
> index 0000000000..b1e67477a0
> --- /dev/null
> +++ b/perl/Git/Packet.pm
> @@ -0,0 +1,118 @@
> +package Git::Packet;
> +use 5.008;

+Avar, who knows more about perl versioning.

As we move it from our tests to the official part of the code we'd want to keep aligned to the rest of the perl parts of the code base?

This whole series looks good to me as a perl bystander.

Thanks, Stefan