Re: [PATCH v2] completion: fix incorrect bash/zsh string equality check

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 28, 2021, 16:36 UTC
Message-ID: <xmqq8rydt8by.fsf@gitster.g>
In-Reply-To: <pull.1096.v2.git.git.1635200973354.gitgitgadget@gmail.com>

"Robert Estelle via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 15 quoted lines

> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 4bdd27ddc87..8ca9b15f21d 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -515,7 +515,7 @@ __gitcomp_file ()
>  # argument, and using the options specified in the second argument.
>  __git_ls_files_helper ()
>  {
> -	if [ "$2" == "--committable" ]; then
> +	if [ "$2" = "--committable" ]; then
>  		__git -C "$1" -c core.quotePath=false diff-index \
>  			--name-only --relative HEAD -- "${3//\\/\\\\}*"
>  	else
>
> base-commit: 225bc32a989d7a22fa6addafd4ce7dcd04675dbf

Thanks. We can trace this back to April 2013, if not earlier. It is sort of surprising that nobody else has noticed it since then X-<.

Will queue.  Thanks, again.