Re: [PATCH] completion: fix incorrect bash/zsh string equality check

From: Robert Estelle <robertestelle@gmail.com>
Date: Oct 8, 2021, 22:17 UTC
Message-ID: <CAMmwyQqw3ebSxnUnYDgignpF5jyca7TgzzduCeKdbzEn97Tddg@mail.gmail.com>
In-Reply-To: <YWCwvOdW/L5aMpr7@camp.crustytoothpaste.net>

On Fri, Oct 8, 2021 at 1:58 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

> It's actually preferable in most cases to use [ and = rather than [[ and
> ==, because the former looks for strict equality and the latter looks
> for pattern matching.

Yep, I agree with these style notes, but went with the prevalent style to avoid confusion. And note that the args here are both quoted, and so are treated as a literal comparison rather than globbed.

That said, whoever maintains that script, since this is a one-line change, I'm not insistent about one way of addressing this or another :)