Re: [PATCH] completion: fix incorrect bash/zsh string equality check

From: Robert Estelle <robertestelle@gmail.com>
Date: Oct 8, 2021, 22:05 UTC
Message-ID: <CAMmwyQpP0m6dTdC-L9abZqk9nJkcYy=j4_s0+EdGDr__pykeXQ@mail.gmail.com>
In-Reply-To: <xmqqbl3zjl5y.fsf@gitster.g>

On Fri, Oct 8, 2021 at 1:50 PM Junio C Hamano <gitster@pobox.com> wrote:

> Would it be equally a valid fix to use "=" instead of "==", or would
> that change the meaning? This is a bash-only piece of code, so use
> of [[ ... ]] is not technically incorrect, but if the basic [] works
> well enough with "=", we should prefer that.

Yes, `[` is preferable for portability and they'd behave the same in this case. I consciously chose to use `[[` because that's what all the other comparisons in that script use. (I think I noted that in the commit message, maybe). I think there's value in consistency, and not enough value of `[` over `[[` to justify changing all the other lines.