Re: [WIP v2 5/5] mv: use update_sparsity() after touching sparse contents

From: Junio C Hamano <gitster@pobox.com>
Date: May 27, 2022, 19:59 UTC
Message-ID: <xmqq8rqm3fxa.fsf@gitster.g>
In-Reply-To: <077a0579-903e-32ad-029c-48572d471c84@github.com>

Victoria Dye <vdye@github.com> writes:

Show 5 quoted lines

> Note that you'll also probably need to check out the file(s) (if moving into
> the cone) or remove them from disk (if moving out of cone). If you don't,
> files moved into cone will appear "deleted" on-disk, and files moved
> out-of-cone that still appear on disk will have 'SKIP_WORKTREE'
> automatically disabled (see [1]).

Does it also imply that we should forbid "git mv" of a dirty path out of the cone? Or is that too draconian and it suffices to tweak the rule slightly to "remove from the worktree when moving a clean path out of cone", perhaps? When a dirty path is moved out of cone, we would trigger the "SKIP_WORKTREE automatically disabled" behaviour and that would be a good thing, I imagine?