Re: [WIP v1 0/4] mv: fix out-of-cone file/directory move logic
- From
Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
- Date
- Mar 31, 2022, 09:28 UTC
- Message-ID
- <CAJyCBOQaojt8u_KaobDuQS7hWRC0Bgf82c_geZj4hOw_HB4ZNA@mail.gmail.com>
- In-Reply-To
- <20220331091755.385961-1-shaoxuan.yuan02@gmail.com>
On Thu, Mar 31, 2022 at 5:20 PM Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> wrote:
Show 26 quoted lines
> > Before integrating 'mv' with sparse-index, I still find some possibly buggy > UX when 'mv' is interacting with 'sparse-checkout'. > > So I kept sparse-index off in order to sort things out without a sparse index. > We can proceed to integrate with sparse-index once these changes are solid. > > Note that this patch is tentative, and still have known glitches, but it > illustrates a general approach that I intended to harmonize 'mv' > with 'sparse-checkout'. > > Shaoxuan Yuan (4): > mv: check if out-of-cone file exists in index with SKIP_WORKTREE bit > mv: add check_dir_in_index() and solve general dir check issue > mv: add advise_to_reapply hint for moving file into cone > t7002: add tests for moving out-of-cone file/directory > > builtin/mv.c | 76 ++++++++++++++++++++++++++++++++--- > t/t7002-mv-sparse-checkout.sh | 72 +++++++++++++++++++++++++++++++++ > 2 files changed, 142 insertions(+), 6 deletions(-) > > > base-commit: 805e0a68082a217f0112db9ee86a022227a9c81b > -- > 2.35.1 >
The original related RFC patch is [1], and this patch should be --in-reply-to [2].
[1] https://lore.kernel.org/git/20220315100145.214054-1-shaoxuan.yuan02@gmail.com/ [2] https://lore.kernel.org/git/97a665fe-07c9-c4f6-4ab6-b6c0e1397c31@github.com/
-- Thanks & Regards, Shaoxuan