git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSOC][PATCH] t4121: modernize test style

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 21, 2023, 20:21 UTC
Message-ID
<xmqq8rgqeplt.fsf@gitster.g>
In-Reply-To
<CADupsJNPVm13iSv84SXpqtP8Dhm_-htPTr59yPs_J=aQzs2FwQ@mail.gmail.com>
Vivan Garg <v.garg.work@gmail.com> writes:
> I'm not sure what you mean by "next re-roll," are you referring to v2? But
> then you said it was fine in this patch, so I'm confused. If I am going to be
> sending a v2, couldn't I just revert the last commit and add this change to the
> same commit?
I am not Victoria, but I think
 * You had two (or more) changes in your patch.
 * She found one of them is good.
 * The other one(s) were found lacking.

When a patch is reviewed and found to be lacking (as a whole), and if you agree with the issues pointed out by the review(s), you'd redo the patch (with either "commit --amend" for a single patch, or "rebase -i" for a series with multiple patches), and produce v2, as if v1 never happened. The act of doing so is colloquially called "to reroll".

Documentation/MyFirstContribution.txt::[[now-what]] may have more details.

Thanks.
Previous: Vivan GargNext: Vivan Garg
Message 4 of 13 in “t4121: modernize test style”
  1. Vivan GargFeb 20, 2023
  2. Victoria DyeFeb 21, 2023
  3. Vivan GargFeb 21, 2023
  4. Junio C HamanoFeb 21, 2023
  5. [GSOC][PATCH v2 0/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  6. [GSOC][PATCH v2 1/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  7. Vivan GargFeb 22, 2023
  8. [GSOC][PATCH v2 0/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  9. [GSOC][PATCH v2 1/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  10. [GSOC][PATCH v2 0/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  11. [GSOC][PATCH v2 1/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  12. Victoria DyeFeb 21, 2023
  13. Vivan GargFeb 21, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.