git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSOC][PATCH] t4121: modernize test style

From
VGVivan Garg <gvivan6@gmail.com>
Date
Feb 20, 2023, 23:51 UTC
Message-ID
<20230220235121.34375-1-gvivan6@gmail.com>

Test scripts in file t4121-apply-diffs.sh are written in old style, where the test_expect_success command and test title are written on separate lines

Signed-off-by: Vivan Garg <gvivan6@gmail.com>
---
Greetings, my name is Vivan Garg. I am currently pursuing a double major
in computer science and finance at the University of Waterloo in Canada. 
I am currently completing my third software developer internship at Morgan
Stanley. As part of my coursework, I studied C and shell scripting, which 
I then applied in internships and personal projects. C++ is the programming 
language that I am most comfortable with right now. Please feel free to 
address me as Vivan, and my pronouns are he/him/his. I meet the requirements 
for GSOC participation. So far, I've either read or skimmed the following 
documents based on prior knowledge: Submitting patches, Coding guidelines, 
Myfirstcontribution.txt, gittutorial, Giteveryday, readme, Hacking-Git, 
General-Microproject-Information, SoC-2023-Ideas, and 
General-Application-Information. I'm looking forward to having a fantastic 
time here! 
 t/t4121-apply-diffs.sh | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/t/t4121-apply-diffs.sh b/t/t4121-apply-diffs.sh
index a80cec9d11..2ff38ededa 100755
--- a/t/t4121-apply-diffs.sh
+++ b/t/t4121-apply-diffs.sh
@@ -16,8 +16,8 @@ echo '1
 7
 8' >file
 
-test_expect_success 'setup' \
-	'git add file &&
+test_expect_success 'setup' '
+	git add file &&
 	git commit -q -m 1 &&
 	git checkout -b test &&
 	mv file file.tmp &&
@@ -27,10 +27,11 @@ test_expect_success 'setup' \
 	git commit -a -q -m 2 &&
 	echo 9 >>file &&
 	git commit -a -q -m 3 &&
-	git checkout main'
+	git checkout main
+'
 
-test_expect_success \
-	'check if contextually independent diffs for the same file apply' \
-	'( git diff test~2 test~1 && git diff test~1 test~0 )| git apply'
+test_expect_success 'check if contextually independent diffs for the same file apply' '
+	( git diff test~2 test~1 && git diff test~1 test~0 )| git apply
+'
 
 test_done
-- 
2.37.0 (Apple Git-136)
Next: Victoria Dye
Message 1 of 13 in “t4121: modernize test style”
  1. Vivan GargFeb 20, 2023
  2. Victoria DyeFeb 21, 2023
  3. Vivan GargFeb 21, 2023
  4. Junio C HamanoFeb 21, 2023
  5. [GSOC][PATCH v2 0/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  6. [GSOC][PATCH v2 1/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  7. Vivan GargFeb 22, 2023
  8. [GSOC][PATCH v2 0/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  9. [GSOC][PATCH v2 1/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  10. [GSOC][PATCH v2 0/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  11. [GSOC][PATCH v2 1/1] t4121: modernize test styleVivan Garg, Feb 21, 2023
  12. Victoria DyeFeb 21, 2023
  13. Vivan GargFeb 21, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.