Re: [GSOC][PATCH] t4121: modernize test style
On Tue, Feb 21, 2023 at 1:21 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> I am not Victoria, but I think
>
> * You had two (or more) changes in your patch.
>
> * She found one of them is good.
>
> * The other one(s) were found lacking.
>
> When a patch is reviewed and found to be lacking (as a whole), and
> if you agree with the issues pointed out by the review(s), you'd
> redo the patch (with either "commit --amend" for a single patch, or
> "rebase -i" for a series with multiple patches), and produce v2, as
> if v1 never happened. The act of doing so is colloquially called
> "to reroll".
>
> Documentation/MyFirstContribution.txt::[[now-what]] may have more
> details.
>
> Thanks.
That makes sense. Thanks for the clarification!