Re: [PATCH 3/6] config.c: create config_reader and the_reader
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 3, 2023, 18:05 UTC
- Message-ID
- <xmqq8rgdg17x.fsf@gitster.g>
- In-Reply-To
- <751ce3e927d392530038006a3f1e3a9538ce2127.1677631097.git.gitgitgadget@gmail.com>
"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:
> A more typical approach would be to put this struct on "the_repository", > but that's a worse fit for this use case since config reading is not > scoped to a repository.
Good thinking.
> We could have also replaced the references to "cf" in callback functions > (which are the only ones left), but we'll eventually plumb "the_reader" > through the callback "*data" arg,...
Good.