Re: [PATCH v2 2/8] config.c: don't assign to "cf_global" directly

From: Jonathan Tan <jonathantanmy@google.com>
Date: Mar 16, 2023, 21:18 UTC
Message-ID: <20230316211821.313426-1-jonathantanmy@google.com>
In-Reply-To: <7555da0b0e012a5fd28ca1a70a4a0897514cd607.1678925506.git.gitgitgadget@gmail.com>

"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +static inline void config_reader_push_source(struct config_source *top)
> +{
> +	if (cf_global)
> +		top->prev = cf_global;

Don't we want to set prev unconditionally here (i.e. set it to NULL if cf_global was NULL)?

Show 12 quoted lines

> +	cf_global = top;
> +}
> +
> +static inline struct config_source *config_reader_pop_source()
> +{
> +	struct config_source *ret;
> +	if (!cf_global)
> +		BUG("tried to pop config source, but we weren't reading config");
> +	ret = cf_global;
> +	cf_global = cf_global->prev;
> +	return ret;
> +}

...since we use it unconditionally here.

The rest looks good.