Re: [PATCH v3 3/8] config.c: create config_reader and the_reader

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2023, 18:57 UTC
Message-ID: <xmqq7cuz9yhp.fsf@gitster.g>
In-Reply-To: <230329.86sfdnvlke.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> But I think this paragraph still does a bad job of justifying this
> direction with reference to existing code.

I thought it read reasonably well, if not perfect, and do not think I am capable of rewriting it better, unfortunately.

Care to suggest a better rewrite?

Show 9 quoted lines

> 	 struct config_options {
> 	        unsigned int respect_includes : 1;
> 	+       unsigned int ignore_system : 1;
> 	+       unsigned int ignore_global : 1;
> 	        unsigned int ignore_repo : 1;
> 	+       unsigned int ignore_local : 1;
> 	        unsigned int ignore_worktree : 1;
> 	        unsigned int ignore_cmdline : 1;
> 	        unsigned int system_gently : 1;

That does look (I am not sure about _local bit, though) well organized, but I suspect that it can be left for a follow-on clean-up series, perhaps?

Thanks.