Re: [PATCH v2 3/4] config: factor out global config file retrieval

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 19, 2024, 23:04 UTC
Message-ID: <xmqq8r4lhqmv.fsf@gitster.g>
In-Reply-To: <Zaor5zNLKE3UXhHM@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

Show 5 quoted lines

> Yeah, you're right that `git_system_config()` is bad in the same way. In
> fact I think it's worse here because we have both `git_config_system()`
> and `git_system_config()`, which has certainly confused me multiple
> times in the past. So I'd be happy to see it renamed, as well, either
> now or in a follow-up patch series.

OK, let's make a note #leftoverbits here and merge the topic down to 'next'. By the time it graduates to 'master', we may have a clean-up patch to rename them.

Thanks, all.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.