Re: [PATCH v1 3/4] config: factor out global config file retrievalync-mailbox>

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 25, 2023, 08:05 UTC
Message-ID: <ZTjMMC1GiPJUXnQm@tanuki>
In-Reply-To: <2b764f52-d3ae-467f-a915-fb73beb247bb@app.fastmail.com>

On Wed, Oct 25, 2023 at 09:33:23AM +0200, Kristoffer Haugsbakk wrote:

Show 17 quoted lines

> On Wed, Oct 25, 2023, at 07:38, Patrick Steinhardt wrote:
> >> What do you guys think the signature of `git_global_config` should be?
> >
> > Either of the following:
> >
> >     - `int git_global_config(char **out_pat)`
> >     - `char **git_global_config(void)`
> >
> > In the first case you'd signal error via a non-zero return value,
> > whereas in the second case you would signal it via a `NULL` return
> > value.
> >
> > To decide which one to go with I'd recommend to check whether there is
> > any similar precedent in "config.h" and what style that precedent uses.
> 
> Okay thanks. So no parameter for determining whether one is writing or
> just reading the file.

This parameter would only exist for the purpose of the error message, right? If so, I think that'd be overkill. If we want to have differing errors depending on how the function is called the best way to handle that would likely be to generate the error message at the callsite instead of in the library itself.

Patrick