Re: [PATCH v1 3/4] config: factor out global config file retrievalync-mailbox>

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Oct 25, 2023, 07:33 UTC
Message-ID: <2b764f52-d3ae-467f-a915-fb73beb247bb@app.fastmail.com>
In-Reply-To: <ZTip7JWm-WRWTImU@tanuki>

On Wed, Oct 25, 2023, at 07:38, Patrick Steinhardt wrote:

Show 13 quoted lines

>> What do you guys think the signature of `git_global_config` should be?
>
> Either of the following:
>
>     - `int git_global_config(char **out_pat)`
>     - `char **git_global_config(void)`
>
> In the first case you'd signal error via a non-zero return value,
> whereas in the second case you would signal it via a `NULL` return
> value.
>
> To decide which one to go with I'd recommend to check whether there is
> any similar precedent in "config.h" and what style that precedent uses.

Okay thanks. So no parameter for determining whether one is writing or just reading the file.

Cheers

-- 
Kristoffer Haugsbakk