Re: [PATCH v3] send-email: make it easy to discern the messages for each patch

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 6, 2024, 01:12 UTC
Message-ID: <xmqq8r1rs39g.fsf@gitster.g>
In-Reply-To: <e3212c0a4ad331685c68c13afcdbced20982ab32.1712364420.git.dsimic@manjaro.org>

Dragan Simic <dsimic@manjaro.org> writes:

> As the final touch, make the above-mentioned prompt emitted without using
> underlined text, which also applies to any other produced prompts, which made
> them somewhat hard on the eyes, especially because the prompt's tailing space
> character was also underlined.

Don't do this, or at least don't do this in the same patch.

Another lesson to learn: resist temptation to grow the scope of the topic. Especially with ascetics, your preference may not be shared by other users, which would easily hold up the main part of the patch you wanted to improve and the reviewers have already spent effort on to polish to be ready. Also are you sure in everybody's environment that ->ornaments() call is available and effective? That is another thing that can hold up the rest of this change. Don't waste your effort so far and build it as a follow-up patch and do so after the dust settles.

Thanks.