git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] send-email: make it easy to discern the messages for each patch

From
DSDragan Simic <dsimic@manjaro.org>
Date
Apr 6, 2024, 01:17 UTC
Message-ID
<235fa26a0803f7a8868fe908e4689bda@manjaro.org>
In-Reply-To
<xmqq8r1rs39g.fsf@gitster.g>
On 2024-04-06 03:12, Junio C Hamano wrote:
Show 17 quoted lines
> Dragan Simic <dsimic@manjaro.org> writes:
> 
>> As the final touch, make the above-mentioned prompt emitted without 
>> using
>> underlined text, which also applies to any other produced prompts, 
>> which made
>> them somewhat hard on the eyes, especially because the prompt's 
>> tailing space
>> character was also underlined.
> 
> Don't do this, or at least don't do this in the same patch.
> 
> Another lesson to learn: resist temptation to grow the scope of the
> topic.  Especially with ascetics, your preference may not be shared
> by other users, which would easily hold up the main part of the
> patch you wanted to improve and the reviewers have already spent
> effort on to polish to be ready.

So many lessons to learn. :) Makes sense, here comes the v4, and an additional follow-up patch.

Show 5 quoted lines
> Also are you sure in everybody's
> environment that ->ornaments() call is available and effective?
> That is another thing that can hold up the rest of this change.
> Don't waste your effort so far and build it as a follow-up patch
> and do so after the dust settles.

According to my research, the "->ornaments(0)" call should work in all environments as expected. It's also officially documented. [1]

[1] https://perldoc.perl.org/Term::ReadLine#ornaments
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “send-email: make it easy to discern the messages for each patch”
  1. send-email: make it easy to discern the messages for each patchDragan Simic, Apr 6, 2024
  2. Junio C HamanoApr 6, 2024
  3. Dragan SimicApr 6, 2024
  4. Junio C HamanoApr 6, 2024
  5. Dragan SimicApr 6, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.