Re: [PATCH v3] send-email: make it easy to discern the messages for each patch

From: Dragan Simic <dsimic@manjaro.org>
Date: Apr 6, 2024, 01:34 UTC
Message-ID: <cd8ed09c0efa712aa93a45558bf6ad8e@manjaro.org>
In-Reply-To: <xmqqttkfqnvm.fsf@gitster.g>

On 2024-04-06 03:30, Junio C Hamano wrote:

Show 13 quoted lines

> Dragan Simic <dsimic@manjaro.org> writes:
> 
>> According to my research, the "->ornaments(0)" call should work in
>> all environments as expected.  It's also officially documented. [1]
>> 
>> [1] https://perldoc.perl.org/Term::ReadLine#ornaments
> 
> Go back to the DESCRIPTION section and realize that it is a
> front-end for different implementations.  The functions are listed
> in separate sections, the first section being "Minimal set of
> supported functions", the other one being "Additional" that may or
> may not be available/effective for everybody.  Which side does
> ornaments fall in that page?

Well spotted, thanks. Perhaps it's the best to leave the prompts as-is until I spend some time to cover the possible Perl platform and package differences properly.

Furthermore, it would be useful to add some color coding to the produced outputs, so the failures and successes could be spotted even more easily, but that's perhaps a can of worms that's best if left unopened.