Re: [PATCH v2 4/5] last-modified: add option '--max-depth' to help output

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 16, 2026, 18:42 UTC
Message-ID: <xmqq8qdx8km3.fsf@gitster.g>
In-Reply-To: <20260116-toon-last-modified-zzzz-v2-4-79e44f2806fe@iotcl.com>

Toon Claes <toon@iotcl.com> writes:

Show 6 quoted lines

> In previous commit option '--max-depth' was added to the documentation.
> To have it also appear in the help output of `git last-modified -h`,
> move the handling of '--max-depth' to parse_options() in
> builtin/last-modified.c itself.
>
> It enables us to change default behavior in a subsequent commit.

This split of the max-depth into two steps does not look right to me. If we are handling the option ourselves here, shouldn't we do so in the same step, so that "git cmd -h" and the synopsis section of the documentation match?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.