Re: [PATCH 2/3] last-modified: document option --max-depth
- From
Toon Claes <toon@iotcl.com>
- Date
- Nov 28, 2025, 18:51 UTC
- Message-ID
- <87qzti0z3s.fsf@iotcl.com>
- In-Reply-To
- <xmqqldjsmv5p.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 33 quoted lines
> Toon Claes <toon@iotcl.com> writes:
>
>> Option --max-depth is supported by git-last-modified(1), because it was
>> added to the diff machinery in a1dfa5448d (diff: teach tree-diff a
>> max-depth parameter, 2025-08-07).
>>
>> This option is useful for everyday use of the git-last-modified(1)
>> command, so document it's existence in the man page and `-h` output.
>>
>> Signed-off-by: Toon Claes <toon@iotcl.com>
>> ---
>> Documentation/git-last-modified.adoc | 9 ++++++++-
>> builtin/last-modified.c | 12 +++++++++++-
>> 2 files changed, 19 insertions(+), 2 deletions(-)
>
> Does this step pass t0450?
>
> fixup! last-modified: document option --max-depth
>
> diff --git a/builtin/last-modified.c b/builtin/last-modified.c
> index ccb7ff66d4..857554e70d 100644
> --- a/builtin/last-modified.c
> +++ b/builtin/last-modified.c
> @@ -523,8 +523,8 @@ int cmd_last_modified(int argc, const char **argv, const char *prefix,
> struct last_modified lm = LAST_MODIFIED_INIT;
>
> const char * const last_modified_usage[] = {
> - N_("git last-modified [--recursive] [--show-trees] [--max-depth=<depth>] [-z] "
> - "[<revision-range>] [[--] <path>...]"),
> + N_("git last-modified [--recursive] [--show-trees] [--max-depth=<depth>] [-z]\n"
> + " [<revision-range>] [[--] <path>...]"),
> NULL
> };Derp, I should have checked that. I knew it could be a problem, but by the time I was about to send the patch I forgot. Sorry about that.
-- Cheers, Toon