git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http: accept https:// proxies again

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 28, 2026, 01:54 UTC
Message-ID
<xmqq8q7z4eg3.fsf@gitster.g>
In-Reply-To
<pull.2161.git.1782580676734.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 16 quoted lines
>  http.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/http.c b/http.c
> index 8e5a4d8bcf..8c0f831365 100644
> --- a/http.c
> +++ b/http.c
> @@ -802,6 +802,8 @@ static int set_curl_proxy_type(CURL *result, const char *protocol)
>  		if (has_proxy_cert_password())
>  			curl_easy_setopt(result, CURLOPT_PROXY_KEYPASSWD,
>  					 proxy_cert_auth.password);
> +
> +		return 0;
>  	}
>  
>  	return -1;

That lack of "return 0" is so glaringly obvious when you point it out like this patch does, and it is surprising it has been missed initially.

From this function nothing returns an error anymore, and looking at the preimage of 663d7abe (http: reject unsupported proxy URL schemes, 2026-05-05) that is the source of the bug, the original did not do anything when the corresponding code did not find and set any proxy settings, either.

So perhaps it is a better fix to make it just a function that returns void with early returns?

Thanks.
Previous: Johannes Schindelin via GitGitGadgetNext: Junio C Hamano
Message 2 of 4 in “http: accept https:// proxies again”
  1. http: accept https:// proxies againJohannes Schindelin via GitGitGadget, Jun 27, 2026
  2. Junio C HamanoJun 28, 2026
  3. Junio C HamanoJun 28, 2026
  4. Junio C HamanoJun 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.