git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http: accept https:// proxies again

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 28, 2026, 22:27 UTC
Message-ID
<xmqq1pdq1etf.fsf@gitster.g>
In-Reply-To
<xmqqjyrj2qsp.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 17 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> From this function nothing returns an error anymore, and looking at
>> the preimage of 663d7abe (http: reject unsupported proxy URL
>> schemes, 2026-05-05) that is the source of the bug, the original did
>> not do anything when the corresponding code did not find and set any
>> proxy settings, either.
>>
>> So perhaps it is a better fix to make it just a function that
>> returns void with early returns?
>
> Nah, I was being stupid.  Disregard the above.
>
> The whole point of 663d7abe was that we wanted to reject what we did
> not recognise, and we cannot do so without returning "good/bad" from
> that function.  The bug was that we did recognise https:// but still
> returned -1 because of the bug, which the patch in the thread fixed.

And as an important bugfix, this patch of course has been fast-tracked. I'll make sure we have it in 'master' before Git 2.55 gets tagged.

Thanks.
Previous: Junio C Hamano
Message 4 of 4 in “http: accept https:// proxies again”
  1. http: accept https:// proxies againJohannes Schindelin via GitGitGadget, Jun 27, 2026
  2. Junio C HamanoJun 28, 2026
  3. Junio C HamanoJun 28, 2026
  4. Junio C HamanoJun 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.