From: Junio C Hamano Date: Sun, 28 Jun 2026 01:54:36 GMT Subject: Re: [PATCH] http: accept https:// proxies again Message-ID: In-Reply-To: "Johannes Schindelin via GitGitGadget" writes: > http.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/http.c b/http.c > index 8e5a4d8bcf..8c0f831365 100644 > --- a/http.c > +++ b/http.c > @@ -802,6 +802,8 @@ static int set_curl_proxy_type(CURL *result, const char *protocol) > if (has_proxy_cert_password()) > curl_easy_setopt(result, CURLOPT_PROXY_KEYPASSWD, > proxy_cert_auth.password); > + > + return 0; > } > > return -1; That lack of "return 0" is so glaringly obvious when you point it out like this patch does, and it is surprising it has been missed initially. From this function nothing returns an error anymore, and looking at the preimage of 663d7abe (http: reject unsupported proxy URL schemes, 2026-05-05) that is the source of the bug, the original did not do anything when the corresponding code did not find and set any proxy settings, either. So perhaps it is a better fix to make it just a function that returns void with early returns? Thanks.