Re: [PATCH v6 4/4] git-rebase: add keep_empty flag

From: Junio C Hamano <jch@google.com>
Date: Apr 19, 2012, 17:53 UTC
Message-ID: <xmqq7gxbsj5e.fsf@junio.mtv.corp.google.com>
In-Reply-To: <20120419130818.GA18339@neilslaptop.think-freely.org>

Neil Horman <nhorman@tuxdriver.com> writes:

Show 9 quoted lines

>> > +is_empty_commit() {
>> > +	tree=$(git rev-parse "$1"^{tree})
>> > +	ptree=$(git rev-parse "$1"^^{tree})
>> > +	return $(test "$tree" = "$ptree")
>> > +}
>> 
>> Could "$1" ever be a root commit without a parent?
>> 
> Strictly speaking, yes.  If that happens, however, the output of git rev-parse

You do not have to speak strictly to see that bug that surfaces internal error message leaking to the end user.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.