From: Junio C Hamano <jch@google.com>
Date: Thu, 19 Apr 2012 17:53:17 GMT
Subject: Re: [PATCH v6 4/4] git-rebase: add keep_empty flag
Message-ID: <xmqq7gxbsj5e.fsf@junio.mtv.corp.google.com>
In-Reply-To: <20120419130818.GA18339@neilslaptop.think-freely.org>

Neil Horman <nhorman@tuxdriver.com> writes:

>> > +is_empty_commit() {
>> > +	tree=$(git rev-parse "$1"^{tree})
>> > +	ptree=$(git rev-parse "$1"^^{tree})
>> > +	return $(test "$tree" = "$ptree")
>> > +}
>> 
>> Could "$1" ever be a root commit without a parent?
>> 
> Strictly speaking, yes.  If that happens, however, the output of git rev-parse

You do not have to speak strictly to see that bug that surfaces internal
error message leaking to the end user.