Re: [PATCH v6 03/10] transport-helper: add 'force' to 'export' helpers
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 7 quoted lines
> Otherwise they cannot know when to force the push or not (other than
> hacks).
>
> Tests-by: Richard Hansen <rhansen@bbn.com>
> Documentation-by: Richard Hansen <rhansen@bbn.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
Didn't we agree that this should be warn, not die?
Show 8 quoted lines
> + if (flags & TRANSPORT_PUSH_FORCE) {
> + if (set_helper_option(transport, "force", "true") != 0)
> + die("helper %s does not support 'force'", data->name);
> + }
> +
> helper = get_helper(transport);
>
> write_constant(helper->in, "export\n");Junio C Hamano <gitster@pobox.com>