From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 11 Nov 2013 23:28:26 GMT
Subject: Re: [PATCH v6 03/10] transport-helper: add 'force' to 'export' helpers
Message-ID: <xmqq7gcejyuc.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1384210507-26561-7-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Otherwise they cannot know when to force the push or not (other than
> hacks).
>
> Tests-by: Richard Hansen <rhansen@bbn.com>
> Documentation-by: Richard Hansen <rhansen@bbn.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---

Didn't we agree that this should be warn, not die?

> +	if (flags & TRANSPORT_PUSH_FORCE) {
> +		if (set_helper_option(transport, "force", "true") != 0)
> +			die("helper %s does not support 'force'", data->name);
> +	}
> +
>  	helper = get_helper(transport);
>  
>  	write_constant(helper->in, "export\n");