git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH v2] remote-bzr: support the new 'force' option

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 12, 2013, 21:01 UTC
Message-ID
<5282971e8103_3b98795e78fd@nysa.notmuch>
In-Reply-To
<1384239808-19065-1-git-send-email-rhansen@bbn.com>
Richard Hansen wrote:
Show 26 quoted lines
> Signed-off-by: Richard Hansen <rhansen@bbn.com>
> ---
> 
> This is a reroll of:
>   http://article.gmane.org/gmane.comp.version-control.git/237607
> based on feedback from Felipe:
>   http://article.gmane.org/gmane.comp.version-control.git/237615
> 
> This patch is an optional extension to Felipe's "transport-helper:
> updates" patch series:
>   http://thread.gmane.org/gmane.comp.version-control.git/237663
> and it requires those changes to work.
> 
>  contrib/remote-helpers/git-remote-bzr | 32 +++++++++++++++++++++++++++++++-
>  contrib/remote-helpers/test-bzr.sh    | 22 +++++++++++++++++++++-
>  2 files changed, 52 insertions(+), 2 deletions(-)
> 
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
> index 7e34532..2f481e9 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -42,6 +42,7 @@ import json
>  import re
>  import StringIO
>  import atexit, shutil, hashlib, urlparse, subprocess
> +import types
No need for this any more.
Show 33 quoted lines
>  NAME_RE = re.compile('^([^<>]+)')
>  AUTHOR_RE = re.compile('^([^<>]+?)? ?[<>]([^<>]*)(?:$|>)')
> @@ -684,7 +685,8 @@ def do_export(parser):
>                  peer = bzrlib.branch.Branch.open(peers[name],
>                                                   possible_transports=transports)
>                  try:
> -                    peer.bzrdir.push_branch(branch, revision_id=revid)
> +                    peer.bzrdir.push_branch(branch, revision_id=revid,
> +                                            overwrite=force)
>                  except bzrlib.errors.DivergedBranches:
>                      print "error %s non-fast forward" % ref
>                      continue
> @@ -718,8 +720,32 @@ def do_capabilities(parser):
>          print "*import-marks %s" % path
>      print "*export-marks %s" % path
>  
> +    print "option"
>      print
>  
> +class InvalidOptionValue(Exception):
> +    pass
> +
> +def get_bool_option(val):
> +    if val == 'true':
> +        return True
> +    elif val == 'false':
> +        return False
> +    else:
> +        raise InvalidOptionValue()
> +
> +def do_option(parser):
> +    global force
> +    (opt, val) = parser[1:3]
I prefer:
  opt, val = parser[1:3]
But not a big deal.
Otherwise the patch looks OK to me.
-- 
Felipe Contreras
Previous: Richard HansenNext: Felipe Contreras
Message 9 of 32 in “transport-helper: add support to delete branches”
  1. 10/10 transport-helper: add support to delete branchesFelipe Contreras, Nov 11, 2013
  2. 00/10 transport-helper: updatesFelipe Contreras, Nov 11, 2013
  3. Junio C HamanoNov 11, 2013
  4. Felipe ContrerasNov 11, 2013
  5. Junio C HamanoNov 11, 2013
  6. Richard HansenNov 12, 2013
  7. Felipe ContrerasNov 12, 2013
  8. remote-bzr: support the new 'force' optionRichard Hansen, Nov 12, 2013
  9. Felipe ContrerasNov 12, 2013
  10. 01/10 transport-helper: fix extra linesFelipe Contreras, Nov 11, 2013
  11. 08/10 fast-import: add support to delete refsFelipe Contreras, Nov 11, 2013
  12. 05/10 fast-export: improve argument parsingFelipe Contreras, Nov 11, 2013
  13. 06/10 fast-export: add new --refspec optionFelipe Contreras, Nov 11, 2013
  14. Junio C HamanoNov 11, 2013
  15. Felipe ContrerasNov 11, 2013
  16. Richard HansenNov 12, 2013
  17. Junio C HamanoNov 12, 2013
  18. Felipe ContrerasNov 12, 2013
  19. Junio C HamanoNov 12, 2013
  20. Felipe ContrerasNov 12, 2013
  21. Junio C HamanoNov 12, 2013
  22. Felipe ContrerasDec 7, 2013
  23. Junio C HamanoDec 9, 2013
  24. Junio C HamanoDec 9, 2013
  25. Felipe ContrerasApr 24, 2014
  26. 03/10 transport-helper: add 'force' to 'export' helpersFelipe Contreras, Nov 11, 2013
  27. Junio C HamanoNov 11, 2013
  28. Felipe ContrerasNov 11, 2013
  29. 09/10 fast-export: add support to delete refsFelipe Contreras, Nov 11, 2013
  30. 07/10 transport-helper: add support for old:new refspecFelipe Contreras, Nov 11, 2013
  31. 04/10 transport-helper: check for 'forced update' messageFelipe Contreras, Nov 11, 2013
  32. 02/10 transport-helper: don't update refs in dry-runFelipe Contreras, Nov 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.