git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] help.c: use SHELL_PATH instead of hard-coded "/bin/sh"

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 10, 2015, 02:21 UTC
Message-ID
<xmqq7fup618m.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150309072040.GA28148@peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> However, that is _not_ what we currently do with run-command's
> use_shell directive. There we put SHELL_PATH as argv[0], and run:
>
>   execv(argv[0], argv);
> ...
> If we want to maintain consistency with the rest of our uses of
> run-command, it would be just your original:
>
>   execl(SHELL_PATH, SHELL_PATH, "-c", shell_cmd.buf, NULL);
>
> That makes the most sense to me, unless we are changing run-command's
> behavior, too. 
OK, then the original under discussion is fine as-is.
Thanks for sanity checking.
Previous: Jeff King
Message 6 of 6 in “git-compat-util.h: move SHELL_PATH default into header”
  1. 1/2 git-compat-util.h: move SHELL_PATH default into headerKyle J. McKay, Mar 8, 2015
  2. 2/2 help.c: use SHELL_PATH instead of hard-coded "/bin/sh"Kyle J. McKay, Mar 8, 2015
  3. Junio C HamanoMar 8, 2015
  4. Kyle J. McKayMar 9, 2015
  5. Jeff KingMar 9, 2015
  6. Junio C HamanoMar 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.