git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-compat-util.h: move SHELL_PATH default into header

From
Kyle J. McKay <mackyle@gmail.com>
Date
Mar 8, 2015, 05:07 UTC
Message-ID
<38be9195b966a027cb050e5a1b47526@74d39fa044aa309eaea14b9f57fe79c>

If SHELL_PATH is not defined we use "/bin/sh". However, run-command.c is not the only file that needs to use the default value so move it into a common header.

Signed-off-by: Kyle J. McKay <mackyle@gmail.com>
---
 git-compat-util.h | 4 ++++
 run-command.c     | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index a3095be9..fbfd10da 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -876,4 +876,8 @@ struct tm *git_gmtime_r(const time_t *, struct tm *);
 #define USE_PARENS_AROUND_GETTEXT_N 1
 #endif
 
+#ifndef SHELL_PATH
+# define SHELL_PATH "/bin/sh"
+#endif
+
 #endif
diff --git a/run-command.c b/run-command.c
index 0b432cc9..3afb124c 100644
--- a/run-command.c
+++ b/run-command.c
@@ -4,10 +4,6 @@
 #include "sigchain.h"
 #include "argv-array.h"
 
-#ifndef SHELL_PATH
-# define SHELL_PATH "/bin/sh"
-#endif
-
 void child_process_init(struct child_process *child)
 {
 	memset(child, 0, sizeof(*child));
---
Next: Kyle J. McKay
Message 1 of 6 in “git-compat-util.h: move SHELL_PATH default into header”
  1. 1/2 git-compat-util.h: move SHELL_PATH default into headerKyle J. McKay, Mar 8, 2015
  2. 2/2 help.c: use SHELL_PATH instead of hard-coded "/bin/sh"Kyle J. McKay, Mar 8, 2015
  3. Junio C HamanoMar 8, 2015
  4. Kyle J. McKayMar 9, 2015
  5. Jeff KingMar 9, 2015
  6. Junio C HamanoMar 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.