From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Mar 2015 02:21:45 GMT
Subject: Re: [PATCH 2/2] help.c: use SHELL_PATH instead of hard-coded "/bin/sh"
Message-ID: <xmqq7fup618m.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150309072040.GA28148@peff.net>

Jeff King <peff@peff.net> writes:

> However, that is _not_ what we currently do with run-command's
> use_shell directive. There we put SHELL_PATH as argv[0], and run:
>
>   execv(argv[0], argv);
> ...
> If we want to maintain consistency with the rest of our uses of
> run-command, it would be just your original:
>
>   execl(SHELL_PATH, SHELL_PATH, "-c", shell_cmd.buf, NULL);
>
> That makes the most sense to me, unless we are changing run-command's
> behavior, too. 

OK, then the original under discussion is fine as-is.

Thanks for sanity checking.