Re: [PATCH v2 03/15] t5520: style fixes

From: Junio C Hamano <gitster@pobox.com>
Date: May 3, 2015, 01:57 UTC
Message-ID: <xmqq7fsqxw1h.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CACRoPnR+OHp1ho-az=C8tE=bczX5h1yEvSozGXVTShB09q1-dg@mail.gmail.com>

Paul Tan <pyokagan@gmail.com> writes:

Show 7 quoted lines

> Just wondering, would it be good to clean up the created repos in the
> above tests to make it clear that they won't be used anymore?
> Something like:
>
>     git init cloned &&
>     test_when_finished "rm -rf cloned" &&
>     ...

It might be a good idea when you are doing the wholesale style fix of the entire script. That was not a part of the scope of my series, so I kept my changes to the minimum and made my additions in line with the existing tests (i.e. new one-time-use repository that is just left behind without being used by others).

Having said that, when it is very clear that each of the new directories are for one-time-use (like the use of them in 5520), I tend to prefer leaving them around, if only to make it easier to insert "exit", go there and manually inspect the situation, which will become necessary when the tests start failing.