[PATCH 05/14] merge: do not check argc to determine number of remote heads
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 26, 2015, 05:25 UTC
- Message-ID
- <1430025967-24479-6-git-send-email-gitster@pobox.com>
- In-Reply-To
- <1430025967-24479-1-git-send-email-gitster@pobox.com>
To reject merging multiple commits into an unborn branch, we check argc, thinking that collect_parents() that reads the remaining command line arguments from <argc, argv> will give us the same number of commits as its input, i.e. argc.
Because what we really care about is the number of commits, let the function run and then make sure it returns only one commit instead.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- builtin/merge.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/builtin/merge.c b/builtin/merge.c index 878f82a..1d4fbd3 100644 --- a/builtin/merge.c +++ b/builtin/merge.c @@ -1185,9 +1185,6 @@ int cmd_merge(int argc, const char **argv, const char *prefix) * to forbid "git merge" into a branch yet to be born. * We do the same for "git pull". */ - if (argc != 1) - die(_("Can merge only exactly one commit into " - "empty head")); if (squash) die(_("Squash commit into empty head not supported yet")); if (fast_forward == FF_NO) @@ -1197,6 +1194,8 @@ int cmd_merge(int argc, const char **argv, const char *prefix) remote_head = remoteheads->item; if (!remote_head) die(_("%s - not something we can merge"), argv[0]); + if (remoteheads->next) + die(_("Can merge only exactly one commit into empty head")); read_empty(remote_head->object.sha1, 0); update_ref("initial pull", "HEAD", remote_head->object.sha1, NULL, 0, UPDATE_REFS_DIE_ON_ERR);
-- 2.4.0-rc3-238-g36f5934