Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 9, 2016, 23:14 UTC
- Message-ID
- <xmqq7fid1noq.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAFY1edbCSPZg892=pVQ=TDo6PRhUdees36Jp7LQ2YB3_jQd4uQ@mail.gmail.com>
Roberto Tyley <roberto.tyley@gmail.com> writes:
> I've not personally run checkpatch.pl (as Peff mentioned, it's not > actually a documented part of the Git project's recommend contribution > workflow) - I'm still trying to understand whether it will restrict > it's errors to just the things that are introduced in a patch,
Yes, it works as a filter to pass a submitted patch through to catch issues on the new lines. You can obviously diff the current state with an empty tree and feed the result to it, which would give you all the existing issues ;-) but that is not very useful.