Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 9, 2016, 18:42 UTC
- Message-ID
- <xmqq4mdh4tel.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <9FBB5AFB-D44C-43A1-A0C5-A5A45675A122@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
> Jeff Merkey made me aware of http://kernelnewbies.org/FirstKernelPatch [2] > where I found checkpatch.pl [3]. Would it make sense to check all commits > that are not in next/master/maint with this script on Travis-CI?
That does not help very much. These changes are already shown to people and dirtied their eyes, and most likely I've already have wasted time tweaking the glitches out locally. The damage has already been done.
It would make a lot of sense if the checkpatch is called inside Roberto Tyley's "pull-request-to-patch-submission" thing, though.