Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

From: Stefan Beller <sbeller@google.com>
Date: Feb 9, 2016, 18:46 UTC
Message-ID: <CAGZ79kb=rkRnP1SnMLtyNkn8DeCAtqoDriYc7051u-Z9isKZoQ@mail.gmail.com>
In-Reply-To: <xmqq4mdh4tel.fsf@gitster.mtv.corp.google.com>

On Tue, Feb 9, 2016 at 10:42 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Lars Schneider <larsxschneider@gmail.com> writes:
>
>> Jeff Merkey made me aware of http://kernelnewbies.org/FirstKernelPatch [2]
>> where I found checkpatch.pl [3]. Would it make sense to check all commits
>> that are not in next/master/maint with this script on Travis-CI?
>
> That does not help very much.  These changes are already shown to
> people and dirtied their eyes, and most likely I've already have
> wasted time tweaking the glitches out locally.  The damage has
> already been done.
>
> It would make a lot of sense if the checkpatch is called inside
> Roberto Tyley's "pull-request-to-patch-submission" thing, though.

Last time I reported a bug/feature request, Roberto was glad to be cc'd as he doesn't read the mailing list in full. So I cc'd him here.