Re: [PATCHv2 1/2] attr: convert to new threadsafe API

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2016, 00:50 UTC
Message-ID: <xmqq7f8uaa4g.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kY00mtzwL4kSz6oXSAb-39=axeTP-ax_FxWcL7Z-sAA4w@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 7 quoted lines

> To explain, you can either have:
>     struct git_attr_result result[2];
> or
>     struct git_attr_result *result = git_attr_result_alloc(check);
> and both are running just fine in a thread. However you should not
> make that variable static. But maybe that is too much common sense
> and hence confusing.

Yup, if you spelled it out that does make sense, but the description given in the patch was just misleading.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.