Re: [PATCH 27/36] attr: convert to new threadsafe API

From: Duy Nguyen <pclouds@gmail.com>
Date: Oct 26, 2016, 14:06 UTC
Message-ID: <CACsJy8BY9QLb=xkGywss+FBo+EBw7O7Kc3P1Kwkxnp0_4ZsnpA@mail.gmail.com>
In-Reply-To: <CAGZ79kb7PaqnyXZ7u0z8Q__ahTLKX8RQwV=dw7vbD4C9LnjOtw@mail.gmail.com>

On Tue, Oct 25, 2016 at 2:18 AM, Stefan Beller <sbeller@google.com> wrote:

Show 17 quoted lines

> On Mon, Oct 24, 2016 at 11:55 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
>>
>> Make that a double-asterisk.  The same problem appears in an updated
>> example in technical/api-gitattributes.txt doc, but the example in
>> the commit log message (below) is correct.
>
> The implementation is actually using a double pointer, see below,
> I forgot commit message and documentation
>
>>>     GIT_ATTR_RESULT_INIT_FOR(myresult, 1);
>>
>> Are you sure about this?  We've called attr_check_initl() already so
>> if this is declaring myresult, it would be decl-after-stmt.
>
> I forgot to update the commit message and Documentation.
> GIT_ATTR_RESULT_INIT_FOR is gone

I was asking whether this function/macro was not thread-safe and found out it didn't exist as well, and it's bed time so I'm stopping. Will continue my skimming on the next re-roll :)

-- 
Duy