Re: [PATCH] git{,-blame}.el: remove old bitrotting Emacs code

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 8, 2018, 17:27 UTC
Message-ID: <xmqq7eqmxysm.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180308094544.7286-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 19 quoted lines

> On Tue, Mar 06 2018, Alexandre Julliard jotted:
> ...
>> I'd recommend that anybody still using it switch to Magit, which is
>> being actively maintained, and IMO superior to git.el in all respects.
>
> I think at this point it's best to remove both of these modes from
> being distributed with Git, per this patch.
>
>  contrib/emacs/.gitignore   |    1 -
>  contrib/emacs/Makefile     |   21 -
>  contrib/emacs/README       |   39 -
>  contrib/emacs/git-blame.el |  483 -------------
>  contrib/emacs/git.el       | 1704 --------------------------------------------
>  5 files changed, 2248 deletions(-)
>  delete mode 100644 contrib/emacs/.gitignore
>  delete mode 100644 contrib/emacs/Makefile
>  delete mode 100644 contrib/emacs/README
>  delete mode 100644 contrib/emacs/git-blame.el
>  delete mode 100644 contrib/emacs/git.el

I agree with the overall direction. The only difference between this and what I had in mind was if we want to leave README that says what you said in the log message. That way, those who just got a new version of tarball and then wonder what happened to these scripts would save one trip to the Internet.