Re: [PATCH] git.el: handle default excludesfile properly

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 4, 2018, 04:34 UTC
Message-ID: <CAPig+cRgBXj+XfT=iq1osxtEA+2dQpnjOTBkwJa94COHM-t9BQ@mail.gmail.com>
In-Reply-To: <CAE09B1Ky1_PKWq17Nm_Uc9sZn7khycR0aK2Z3AHnyjYoPMy8Qg@mail.gmail.com>

On Sat, Mar 3, 2018 at 9:57 PM, Dorab Patel <dorabpatel@gmail.com> wrote:

Show 6 quoted lines

> Thanks for reviewing and locating the commits.
>
> OK, I'll re-roll and add the relevant commits. It may take some time.
>
> Should I just send the revised patch as a separate thread (with the
> relevant commits and history)?

That would work. You can use "git format-patch -v2 ..." to mark the patch as "[PATCH v2]", and "git send-email --in-reply-to=20180303034803.21589-1-dorabpatel@gmail.com ..." to tie it back to this thread when you send it.

As a an aid to reviewers, it's a good idea to add commentary explaining what changed since v1 and provide a link back to v1, like this[1]. Place the commentary below the "---" line following your sign-off.

(One more minor comment: etiquette on this list is to avoid top-posting [2].)

Thanks.

[1]: https://public-inbox.org/git/20180303034803.21589-1-dorabpatel@gmail.com/ [2]: https://lkml.org/lkml/2005/1/11/111