Re: [PATCH v2] git{,-blame}.el: remove old bitrotting Emacs code

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mar 13, 2018, 18:53 UTC
Message-ID: <87woyfq02x.fsf@evledraar.gmail.com>
In-Reply-To: <xmqqbmfr3jke.fsf@gitster-ct.c.googlers.com>

On Tue, Mar 13 2018, Junio C. Hamano jotted:

Show 14 quoted lines

> Martin Ågren <martin.agren@gmail.com> writes:
>
>>> +Emacs's own support for Git got better than what was offered by these
>>> +modules, or was superseded by popular 3rd-party Git modes such as
>>> +Magit.
>>
>> This somehow reads like "Emacs's own support ... was superseded ...".
>> Maybe that's what you mean, but i'm not sure. Perhaps s/, was superseded
>> by/. There are also/.
>
> I think "There are also" is way better.  If we really want to sy
> superseded, perhaps "The features these modules offered were
> superseded by Emacs's own support in VC mode, and popular
> third-party Git modes e.g. Magit" is what we can say.

I sent a v3 a few days ago which addressed this, it's at 20180310184545.16950-1-avarab@gmail.com (https://public-inbox.org/git/20180310184545.16950-1-avarab@gmail.com/) but I see that I screwd up the In-Reply-To (I still don't have this fully automated) so that wasn't part of this thread, sorry.

That changes this wording, among other fixes (noted in the tbdiff).