Re: Feature Request - Better i18n support

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 9, 2023, 22:35 UTC
Message-ID: <xmqq7cvp8sdu.fsf@gitster.g>
In-Reply-To: <ZApdaAMrkmFcxarq@tapette.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 5 quoted lines

> More specifically, I think it could be fixed for progress output, but
> there are a few places in diff output where it couldn't because it might
> be parsed.  Would you be willing to try a patch for this?  I think the
> code you're probably thinking about is in progress.c (search for "%%"),
> but there might be other places you have in mind as well.

Ah, my earlier grep missed this, as it tried only to catch [fdi]%% and the progress thing uses "%u%%" like so:

		if (percent != progress->last_percent || progress_update) {
			progress->last_percent = percent;

			strbuf_reset(counters_sb);
			strbuf_addf(counters_sb,
				    "%3u%% (%"PRIuMAX"/%"PRIuMAX")%s", percent,
				    (uintmax_t)n, (uintmax_t)progress->total,
				    tp);
			show_update = 1;
		}

With the PRIuMAX thing, it won't be as simple as enclosing the entire format string inside _(), though.

Thanks.