Re: Feature Request - Better i18n support

From: Emir SARI <emir_sari@icloud.com>
Date: Mar 9, 2023, 23:12 UTC
Message-ID: <9F4F74FC-B424-4BF7-9F9D-8A821C89B442@icloud.com>
In-Reply-To: <xmqqfsad8tap.fsf@gitster.g>

Hello,

Thank you very much for the prompt responses.

Show 9 quoted lines

> Junio C Hamano <gitster@pobox.com> şunları yazdı (10 Mar 2023 01:16):
> 
> These are currently not even marked with _() to be translatable, and
> it should be just the matter of enclosing them in _().
> 
> If these should be translated in the first place, that is.  I do not
> think these are originally meant to be machine parseable (it is
> shown as part of "git apply --summary"), but existing users may
> already be abusing them as such.

My general idea is, if the percentages appear with the translated strings, they should use the localised format. Otherwise if they only appear with some machine-output without any localised context it is perfectly fine to leave them as-is.

Show 7 quoted lines

> brian m. carlson <sandals@crustytoothpaste.net> şunları yazdı (10 Mar 2023 01:27):
> 
> More specifically, I think it could be fixed for progress output, but
> there are a few places in diff output where it couldn't because it might
> be parsed.  Would you be willing to try a patch for this?  I think the
> code you're probably thinking about is in progress.c (search for "%%"),
> but there might be other places you have in mind as well.

The progress output was my biggest motivation in reporting this. It was rather disturbing to see translated strings with unlocalised values.

I’d love to assist in testing any possible patches. Just let me know of any possible scenarios, and I’ll get back to you. Being in vacation, I have plenty of time available.

> Can you clarify what places you're thinking about?  Is this printing
> decimal values, or is it parsing decimal values?  If we know what
> specifically is affected (for example, an affected command or message),
> it's a lot easier to fix this.

In general, I am not concerned with parsing, it’s more about printing them. As with the percentage situation, having unlocalised content with localised strings is not ideal. For instance, my ideal pull output would look like this:

Nesneler sayılıyor: %100 (12/12), bitti. Delta sıkıştırması 8 iş parçacığı kullanıyor Nesneler sıkıştırılıyor: %100 (7/7), bitti. Nesneler yazılıyor: %100 (7/7), 3,79 KiB | 3,79 MiB/sn, bitti.

As I’ve indicated above, I am ready to test anything you might throw at me. :)

Thank you again very much!

Best regards, Emir (𐰽𐰺𐰍)

** E-mail needs to stay simple ** Use plain text e-mail