Re: [PATCH v2 06/13] treewide: trivial conversions of `repo_has_object_file()`

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 28, 2025, 21:40 UTC
Message-ID: <xmqq7c34arsk.fsf@gitster.g>
In-Reply-To: <20250425-pks-object-store-cleanups-v2-6-63f1695b7700@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 5 quoted lines

> As the comment of `repo_has_object_file()` and its `_with_flags()`
> variant tells us, these functions are considered to be deprecated in
> favor of `has_object()`. The benefit of the replacement is better
> defaults: it doesn't fetch missing objects via promisor remotes, and
> neither does it reload packfiles if an object wasn't found by default.

The reason why the "better default" being "better" is not clear to readers of this paragraph.

It would be better if too many places need to pass an extra flag to disable lazy fetching in the current code, for example, in which case we would instead have fewer very selected places that would pass an extra flag to lazily fetch (or even better, see has_object() fail and then invoke a lazy fetch themselves) while majority of places would just work with the plain vanilla local repository state without having to worry about lazy fetching at all. Without explaining why it is a "better default", it is a bit hard to justify "the benefit of the replacement".

This is common to this and the previous step.