Re: [PATCH 00/13] object-store: a handful of cleanups
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Apr 23, 2025, 17:20 UTC
- Message-ID
- <CAOLa=ZQ45v33yj2bUNrN6ZJYawR2KVyjHAtsY0RZ58fkhkTbSw@mail.gmail.com>
- In-Reply-To
- <20250423-pks-object-store-cleanups-v1-0-81f8411a5d08@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 20 quoted lines
> Hi, > > this patch series contains a handful of cleanups to the object store > subsystem: > > - A couple of definitions are moved out of "object-store.h" as they > belong to other subsystems. > > - Some functions are dropped and/or renamed. > > - The biggest part is the removal of `repo_has_object_file()`. This > function and its `_with_flags()` variant are marked as deprecated, > with the replacement being `has_object()`. The benefit of that > function is that it doesn't reload packfiles and doesn't fetch > promisor objects by default so that it becomes more explicit when > one really wants to do so. > > These cleanups are in preparation for getting rid of `the_repository` in > "object-store.c". >
Apart from the few nits I mentioned, the series looks great! I must say the split of commits was really nice to go through :)
[snip]